Skip to content

Instantly share code, notes, and snippets.

@xb4dc0d3
Last active March 19, 2020 07:08
Show Gist options
  • Save xb4dc0d3/deda421a562f88ac9436e31302584f0e to your computer and use it in GitHub Desktop.
Save xb4dc0d3/deda421a562f88ac9436e31302584f0e to your computer and use it in GitHub Desktop.
# Bad (not consistent variable and function name)
@api_view(["GET"])
@permission_classes([IsAuthenticated])
def get_all_mahasiswa(request):
mahasiswa = Mahasiswa.objects.all()
json_mahasiswa = MahasiswaDetailSerializer(mahasiswa, many=True)
return Response(json_mahasiswa.data)
@api_view(["GET"])
@permission_classes([IsAuthenticated])
def get_supervisor_lembaga(request):
supervisor_lembaga = SupervisorLembaga.objects.all()
serializer = SupervisorLembagaSerializer(supervisor_lembaga, many=True)
return Response(serializer.data)
# Good
@api_view(["GET"])
@permission_classes([IsAuthenticated])
def get_all_mahasiswa(request):
mahasiswa = Mahasiswa.objects.all()
serializer = MahasiswaDetailSerializer(mahasiswa, many=True)
return Response(serializer.data)
@api_view(["GET"])
@permission_classes([IsAuthenticated])
def get_all_supervisor_lembaga(request):
supervisor_lembaga = SupervisorLembaga.objects.all()
serializer = SupervisorLembagaSerializer(supervisor_lembaga, many=True)
return Response(serializer.data)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment