Created
October 12, 2018 22:55
-
-
Save xhocquet/4e07f430efd186ab69828961bdd7b7a3 to your computer and use it in GitHub Desktop.
Rubocop + CircleCI
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# One of the steps, insert where you wish: | |
- run: | |
name: run rubocop | |
command: | | |
source /home/circleci/.rvm/scripts/rvm | |
rvm --default use 2.3.1 | |
bash bin/rubocop.sh | |
# Remove the RVM lines if not needed for your setup |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#!/usr/bin/env bash | |
# Inspired by http://takemikami.com/2018/01/30/RubocopPullRequestCI.html | |
BASE_REMOTE=origin | |
BASE_BRANCH=master | |
git fetch $BASE_REMOTE $BASE_BRANCH | |
diff_list=() | |
commit_list=`git --no-pager log --no-merges $BASE_REMOTE/$BASE_BRANCH...HEAD | grep -e '^commit' | sed -e "s/^commit \(.\{8\}\).*/\1/"` | |
for f in `git --no-pager diff $BASE_REMOTE/$BASE_BRANCH...HEAD --name-only`; do | |
for c in $commit_list; do | |
diffs=`git --no-pager blame --follow --show-name -s $f | grep $c | sed -e "s/^[^ ]* *\([^ ]*\) *\([0-9]*\)*).*$/\1:\2/"` | |
for ln in $diffs; do | |
diff_list+=("$ln") | |
done | |
done | |
done | |
err_count=0 | |
err_lines=() | |
while read line; do | |
for m in ${diff_list[@]}; do | |
if [[ "$line" =~ "$m" ]]; then | |
err_count=$(($err_count + 1)) | |
err_lines+=("$line") | |
break | |
fi | |
done | |
done < <(bundle exec rubocop --format emacs) | |
if [ $err_count -ne 0 ]; then | |
echo -e "\033[31m$err_count Lint Errors\033[0;39m" | |
echo -e "\033[31m-----------------------------------\033[0;39m\n" | |
printf '\033[31m%s\n' "${err_lines[@]}" | |
echo -e "\033[31mPlease resolve them before merging.\033[0;39m" | |
exit 1 | |
fi |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment