Created
March 7, 2018 06:44
-
-
Save ygrenzinger/2dba8b7d9d1cd955165d540c98bcd18a to your computer and use it in GitHub Desktop.
Proposal for skipPattern on ZipKin Rest Template interceptor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/* | |
* Copyright 2013-2017 the original author or authors. | |
* | |
* Licensed under the Apache License, Version 2.0 (the "License"); | |
* you may not use this file except in compliance with the License. | |
* You may obtain a copy of the License at | |
* | |
* http://www.apache.org/licenses/LICENSE-2.0 | |
* | |
* Unless required by applicable law or agreed to in writing, software | |
* distributed under the License is distributed on an "AS IS" BASIS, | |
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | |
* See the License for the specific language governing permissions and | |
* limitations under the License. | |
*/ | |
package org.springframework.cloud.sleuth.instrument.web.client; | |
import org.springframework.cloud.sleuth.ErrorParser; | |
import org.springframework.cloud.sleuth.Tracer; | |
import org.springframework.cloud.sleuth.instrument.web.HttpSpanInjector; | |
import org.springframework.cloud.sleuth.instrument.web.HttpTraceKeysInjector; | |
import org.springframework.http.HttpRequest; | |
import org.springframework.http.client.ClientHttpRequestExecution; | |
import org.springframework.http.client.ClientHttpRequestInterceptor; | |
import org.springframework.http.client.ClientHttpResponse; | |
import java.io.IOException; | |
import java.util.regex.Pattern; | |
/** | |
* Interceptor that verifies whether the trance and span id has been set on the request | |
* and sets them if one or both of them are missing. | |
* | |
* @author Marcin Grzejszczak | |
* @author Spencer Gibb | |
* @since 1.0.0 | |
* | |
* @see org.springframework.web.client.RestTemplate | |
*/ | |
public class TraceRestTemplateInterceptor extends AbstractTraceHttpRequestInterceptor | |
implements ClientHttpRequestInterceptor { | |
private final ErrorParser errorParser; | |
private final Pattern skipPattern; | |
public TraceRestTemplateInterceptor(Tracer tracer, HttpSpanInjector spanInjector, | |
HttpTraceKeysInjector httpTraceKeysInjector, ErrorParser errorParser) { | |
super(tracer, spanInjector, httpTraceKeysInjector); | |
this.errorParser = errorParser; | |
this.skipPattern = Pattern.compile(""); | |
} | |
public TraceRestTemplateInterceptor(Tracer tracer, HttpSpanInjector spanInjector, | |
HttpTraceKeysInjector httpTraceKeysInjector, ErrorParser errorParser, Pattern skipPattern) { | |
super(tracer, spanInjector, httpTraceKeysInjector); | |
this.errorParser = errorParser; | |
this.skipPattern = skipPattern; | |
} | |
@Override | |
public ClientHttpResponse intercept(HttpRequest request, byte[] body, | |
ClientHttpRequestExecution execution) throws IOException { | |
boolean skip = this.skipPattern.matcher(request.getURI().getPath()).matches(); | |
if (skip) { | |
publishStartEvent(request); | |
} | |
return response(request, body, execution); | |
} | |
private ClientHttpResponse response(HttpRequest request, byte[] body, | |
ClientHttpRequestExecution execution) throws IOException { | |
try { | |
return new TraceHttpResponse(this, execution.execute(request, body)); | |
} catch (Exception e) { | |
if (log.isDebugEnabled()) { | |
log.debug("Exception occurred while trying to execute the request. Will close the span [" + currentSpan() + "]", e); | |
} | |
this.errorParser.parseErrorTags(currentSpan(), e); | |
finish(); | |
throw e; | |
} | |
} | |
} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The need is to filter POST request to xxx/api/applications when using Spring Boot Admin Client