This is about how to split a GitHub pull request, following a real in-the-wild example.
So it happened that I once wanted to fix a bug (#832) on the shelljs repository.
I forked the repository, cloned it and created a new branch called ln-directory-dest. I fixed the bug, created a pull request, and implemented initial review feedback.
At this point, I had added the commits A, B, C, D, E and [F](https://github.com/Loilo/shelljs/commit/946ab48bf5cf9c8aac03407
This is about how to split a GitHub pull request, following a real in-the-wild example.
So it happened that I once wanted to fix a bug (#832) on the shelljs repository.
I forked the repository, cloned it and created a new branch called ln-directory-dest. I fixed the bug, created a pull request, and implemented initial review feedback.
At this point, I had added the commits A, B, C, D, E and [F](https://github.com/Loilo/shelljs/commit/946ab48bf5cf9c8aac03407
| #!/usr/bin/env bash | |
| # Name: Check for domain name availability | |
| # Author: ype | |
| # Source: https://github.com/ype/canihazdomain | |
| # Based On: linuxconfig.org | |
| # Usage: | |
| # canihazdomain domain_name |
| #!/usr/bin/env bash | |
| HYPERLINK="$1" | |
| canyoudigit () { | |
| RETVAL=1; | |
| while [ $RETVAL -ne 0 ] | |
| do | |
| clear | |
| VAL=$(dig "$HYPERLINK") |
| #!/usr/bin/env bash | |
| ## -*- Mode: Sh -*- ## | |
| ################################################################################ | |
| ################################################################################ | |
| ## ## | |
| ## daily_bg.sh ## | |
| ## Created: 02-09-2015 ## | |
| ## Author: Anton Strilchuk <[email protected]> ## | |
| ## URL: https://env.sh ## | |
| ## Version: ## |
| ### -*- Mode: Perl -*- ### | |
| ################################################################################ | |
| ################################################################################ | |
| ### ### | |
| ### usrgrp ### | |
| ### Created: 01-09-2015 ### | |
| ### Author: Anton Strilchuk <[email protected]> ### | |
| ### URL: https://env.sh ### | |
| ### Version: 0.0.0.1 ### | |
| ### Last-Updated: 01-09-2015 ### |
| # To show everytime your shell opens add this function to the bottom of your bash_profile,bashrc,zshrc | |
| function unix_tip() { | |
| while [ "$count" -ne 1 ]; do | |
| type pandoc >/dev/null 2>&1 || { echo >&2 "Pandoc is required, but not installed. If you have homebrew try: brew install pandoc"; break; } | |
| type xmlstarlet >/dev/null 2>&1 || { echo >&2 "xmlstarlet is required, but not installed. If you have homebrew try: brew install xmlstarlet"; break; } | |
| ping -c1 8.8.8.8 >> /dev/null | |
| if [ $? -eq 0 ]; then | |
| curl -s https://raw.githubusercontent.com/jlevy/the-art-of-command-line/master/README.md \ | |
| | pandoc -f markdown -t html \ |
| [core] | |
| editor = emacsclient -d -c | |
| excludesfile = /Users/astrilchuk/.gitignore_global | |
| quotepath = false | |
| [user] | |
| name = Anton Strilchuk | |
| email = [email protected] | |
| [mergetool] |
| csvsort repo_branch_master.csv >> repo_bmaster_sorted.csv && sed -e '1s/.*_.*\,.*\,.*\,.*/line\,url\,tag\,branch/g' repo_bmaster_sorted.csv > repo_bmaster.csv |
| for i in $(cat repo_links_list.txt); do echo $(git ls-remote --get-url "$i") $(git ls-remote "$i" master) | tr ' ' ',' >> repo_branch_master.csv; done |
