Skip to content

Instantly share code, notes, and snippets.

@yuriy77k

yuriy77k/ETH_SafeUpgradeableTokenERC20_report.md Secret

Forked from MrCrambo/ETH_SafeUpgradeableTokenERC20_report.md
Created May 30, 2019 07:37
Show Gist options
  • Save yuriy77k/c15a757737adcf079bd6e92156796231 to your computer and use it in GitHub Desktop.
Save yuriy77k/c15a757737adcf079bd6e92156796231 to your computer and use it in GitHub Desktop.
Download ZIP
Raw
ETH_SafeUpgradeableTokenERC20_report.md

Summary

This is the report from a security audit performed on SafeUpgradeableTokenERC20 by MrCrambo.

The audit focused primarily on the security of SafeUpgradeableTokenERC20 smart contract.

In scope

  1. https://github.com/guylando/EthereumSmartContracts/blob/master/SafeUpgradeableTokenERC20/contracts/SafeUpgradeableTokenERC20.sol

Findings

In total, 4 issues were reported including:

  • 0 high severity issues.

  • 0 medium severity issues.

  • 2 owner privilegies issues.

  • 2 low severity issues.

Security issues

1. Owner privilegies

Severity: owner privilegies

Description

  1. Pausers set by owner can pause any time they wants.
  2. upgradeMaster can change upgradeMaster to any address he wants without checking it for zero address.

2. Extra functions

Severity: low

Description

Function _burnFrom is never used and could be removed.

3. Zero address checking

Severity: low

Description

In constructor and setUpgradeMaster there are no zero address checking.

Conclusion

Smart contract contains low severity issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment