Skip to content

Instantly share code, notes, and snippets.

@yuriy77k
Forked from RideSolo/ETH_SymVerse_report.md
Created June 8, 2019 09:43
Show Gist options
  • Save yuriy77k/de893de91b8a0f5e185d930329376518 to your computer and use it in GitHub Desktop.
Save yuriy77k/de893de91b8a0f5e185d930329376518 to your computer and use it in GitHub Desktop.

SymVerse Audit Report.

1. Summary

This document is a security audit report performed by RideSolo, where SymVerse has been reviewed.

2. In scope

  • SymToken.sol github commit hash d38e09b7c90763c283215c6da043e720b324f98f.

3. Findings

** 3 issues** were reported including:

  • 1 medium severity issue.

  • 2 low severity issues.

3.1. Decrease Allowance

Severity: low

Description

decreaseAllowance throw in case if the value to be substracted is higher than the amount that is allowed, if the address owner wants to change the value allowed by reducing it and the spender withdraw a part of it before, the function might throw and give more chances for the spender to take the rest of the allowed value.

The value should be set to zero if the value to be subtracted is higher than the allowance.

Code snippet

https://github.com/RideSolo/SmartContract-1/blob/master/SymToken.sol#L244

3.2. Owner Priviliges

Severity: medium

Description

  • Pause/Unpause token transfers and approvals code snippet.
  • Freeze/Unfreeze tokens on every possible account address by the contract owner or delegator code snippet.

3.3. Known vulnerabilities of ERC-20 token

Severity: low

Description

  1. It is possible to double withdrawal attack. More details here
  2. Lack of transaction handling mechanism issue. WARNING! This is a very common issue and it already caused millions of dollars losses for lots of token users! More details here

Recommendation

Add the following code to the transfer(_to address, ...) function:

require( _to != address(this) );

4. Conclusion

This contract is subjected to high control from the owners, token holders should be aware of the risks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment