Last active
August 29, 2015 14:03
-
-
Save CarlosGabaldon/37e3e04849a8e02a2513 to your computer and use it in GitHub Desktop.
pr_review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Story 1 | |
| - Liked the fix for the content-length warning | |
| - Solved the problem in common expected way with includes | |
| - Added good commit notes on changes, assumptions, and possible future enhancements | |
| Story 2 | |
| - Liked the addition of the migration for production and update seed for dev | |
| - + for added deal_heler unit test | |
| Story 3 | |
| - Used Timecop, which is the most common way to solve this time issue | |
| Story 4 | |
| - Fairly clean approach | |
| - Extra points for integration and unit tests | |
| - Not sure why app/views/advertisers/index.html.erb was modified | |
| Overall | |
| - Clean implementation, most of the problems were solved with the most common expected ways | |
| - Easy to follow PR | |
| - Very detailed commit comments | |
| - Liked the notes on how future improvements could be made to the overall desgin of the publisher importer |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment