Carlos Gabaldon CarlosGabaldon

Install Go

I hereby claim:

To claim this, I am signing this object:

JIRA supports easily linking issues to confluence pages or URI's. You can also embed JIRA issue numbers in confluence pages to link to a JIRA issue.
Linking JIRA projects to confluence pages requires admin support: https://confluence.atlassian.com/display/APPLINKS/Creating+Links+Between+Projects
Rally supports adding links into an story/incident as a free form link, but it is buried in the discussion tab.

	#include <SD.h>
	#define POTENTIOMETER_PIN A0

	int potValue;
	int previousPotValue;
	bool buttonState = HIGH;
	bool previousButtonState = HIGH;
	bool recording = false; // Flag to indicate whether data recording is active
	unsigned long startTime = 0; // Variable to store the start time
	int rateOfChange;

	With his code exercise he took fairly standard approaches with solving the problems. Overall, very clean implemenation.

	What impressed me was that he put together detailed gists for each of the stories explain his design decisions.

	Story 1: https://gist.github.com/pmanrubia/383adcb2dfe1d1ab5bf9
	Story 2: https://gist.github.com/pmanrubia/dcc7dd8984c5ac45fe48
	Story 3: https://gist.github.com/pmanrubia/69fbaf68d22db91b667b
	Story 4: https://gist.github.com/pmanrubia/d7984fb613c2f6859770

	Code Review - FELIX CLACK (Rails)

	Colin Ross
	10:37 AM (1 hour ago)

	to Hanna.Park, Glenn, me
	#1) Nice abstraction that would support adding different formats later and reuse. +1 for tests.
	#2) Whilst I think bringing in Draper is a bit overkill, the idea of utilizing a decorator pattern is good, and the implementation is clean and hits all the marks.
	#3) Ship it.
	#4) Bonus points for cleaning up the database.yml when he was there. Not sure if I really prefer the solution of essentially denormalizing the fields to the deal object, but credit for going that route successfully and keeping the code as straightforward as possible-- something that can be difficult when doing performance-related changes.

	Story 1
	- Solved the problem in common expected way with includes
	- Would have liked to see a few commit notes on the change, expaling any assumptions and/or possible future enhancements

	Story 2
	- Liked the addtion of the ThemePathResovler to abstract the paths
	- + for unit test

	Story 3
	- Used Timecop, which is the most common way to solve this time issue

	Story 1
	- Liked the fix for the content-length warning
	- Solved the problem in common expected way with includes
	- Added good commit notes on changes, assumptions, and possible future enhancements

	Story 2
	- Liked the addition of the migration for production and update seed for dev
	- + for added deal_heler unit test

	Story 3

	- Very clean implementation
	- Easy to follow PR
	- Liked the abstaction of adding the eager loading to the Deal model behind the very descriptive all_with_advertisers class method
	- Liked that the code was profiled to track before and after perfomance improvements
	- Very nice that unit test and migration was added for the DRY'ing up of all the city specific entertainment themes
	- Did not use TimeCop for addressing the bad time test, but the choosen method was clean and effective
	- The publisher importer solution was effective enough for the code exericse, liked that there were notes on it's limitations, unit test, and how it could be improved.
	- Extra points for thinking about the Law of Demeter and how to better lessen coupling.

	Requirements Management (60%) - 48 hours
	- gathering - do you have any more details than just one line
	- analyzing - what do you really want with this story, let's break things down this way
	- writing stories - let we me help with re-writing this story myself
	- investigating future epics - spikes, tech research, high level est
	- participating in Requirements Team meetings - providing input into future work for requirements team, reviewing and sharing CR's with team, trying to keep general team updated on up coming work
	- attending meetings
	- responding to emails
	- responding to pivotal questions
	- trying to manage changing team priorities by keeping people focused while things are up in the air