CarlosGabaldon · July 14, 2014 19:00
diff --git a/pr_review_felix_clack b/pr_review_felix_clack
 Code Review - FELIX CLACK (Rails)

 Colin Ross
 10:37 AM (1 hour ago)

 to Hanna.Park, Glenn, me 
 #1) Nice abstraction that would support adding different formats later and reuse. +1 for tests.
 #2) Whilst I think bringing in Draper is a bit overkill, the idea of utilizing a decorator pattern is good, and the implementation is clean and hits all the marks.
 #3) Ship it.
 #4) Bonus points for cleaning up the database.yml when he was there. Not sure if I really prefer the solution of essentially denormalizing the fields to the deal object, but credit for going that route successfully and keeping the code as straightforward as possible-- something that can be difficult when doing performance-related changes.
 
 Overall: Easy to read, well formatted code-- in line with our best practices and development style. Generally intelligent decisions with rationale. Avoided the obvious performance fix of just using eager loading, which, isn't a full fix in this situation.  +1 from me to get a phone interview.

 Colin
	Code Review - FELIX CLACK (Rails)

	Colin Ross
	10:37 AM (1 hour ago)

	to Hanna.Park, Glenn, me
	#1) Nice abstraction that would support adding different formats later and reuse. +1 for tests.
	#2) Whilst I think bringing in Draper is a bit overkill, the idea of utilizing a decorator pattern is good, and the implementation is clean and hits all the marks.
	#3) Ship it.
	#4) Bonus points for cleaning up the database.yml when he was there. Not sure if I really prefer the solution of essentially denormalizing the fields to the deal object, but credit for going that route successfully and keeping the code as straightforward as possible-- something that can be difficult when doing performance-related changes.

	Overall: Easy to read, well formatted code-- in line with our best practices and development style. Generally intelligent decisions with rationale. Avoided the obvious performance fix of just using eager loading, which, isn't a full fix in this situation. +1 from me to get a phone interview.

	Colin