Egor Bogatov EgorBo

Roslyn:

#85921: Require annotation for layout with pack or size
#85784: Require AllowUnsafeBlocks for the safe keyword
#85773: Avoid constructor recursion
#85756: Suppress "unnecessary unsafe"
#85131: Fix a race in version decoding
#85118: Display unsafe modifier on interface members too
#84888: Fix new() constraint handling in declarations
#84860: Add remaining public APIs

Legend

Statistical Test threshold: 10%, the noise filter: 2 ns
Result is conclusion: Slower|Faster|Same|Noise|Unknown. Noise means that the difference was larger than 10% but not 2 ns.
Ratio = Base/Diff (the higher the better).
Alloc Delta = Allocated bytes diff - Allocated bytes base (the lower the better)

Statistics

Total: 52498

Legend

Statistical Test threshold: 10%, the noise filter: 2 ns
Result is conclusion: Slower|Faster|Same|Noise|Unknown. Noise means that the difference was larger than 10% but not 2 ns.
Ratio = Base/Diff (the higher the better).
Alloc Delta = Allocated bytes diff - Allocated bytes base (the lower the better)

Statistics

Total: 52498

How to run jit-diffs for changes in the managed code

All commands are in powershell, should be pretty much the same for bash and non-windows platforms

build everything we're going to need:

.\build.cmd Clr+Libs -c Release ;; .\build.cmd Clr -c Checked ;; cd .\src\tests\ ;; .\build.cmd Release generatelayoutonly ;; cd ..\..

Make a copy of the test core_root (will be a baseline):

DOTNET_SYSTEM_NET_SOCKETS_INLINE_COMPLETIONS=1 noticeably improves simple TE benchmarks such as the following ones on all UNIX archs. From my understanding, it avoids dispatching from the event-thread to threadpool and does the work in the same thread it got request from.

TE Benchmark	Baseline, RPS	MyTest, RPS	diff, %
ARM64 Platform-JSON PGO	661,663	778,925	+17.72%
ARM64 Platform-Caching PGO	186,188	218,004	+17.09%
ARM64 Platform-Plaintext PGO	6,933,964	7,563,428	+9.08%

x64 Platform-JSON PGO	1,299,388	1,432,200	+10.22%
x64 Platform-Caching PGO	413,123	445,144	+7.75%

	wget https://dot.net/v1/dotnet-install.sh -O ~/dotnet-install.sh
	chmod +x ~/dotnet-install.sh
	~/./dotnet-install.sh -Channel "8.0" -InstallDir ~/dotnet
	~/./dotnet-install.sh -Channel "9.0" -InstallDir ~/dotnet
	echo -e '\nexport DOTNET_ROOT=~/dotnet\nexport PATH=$DOTNET_ROOT:$DOTNET_ROOT/tools:$PATH' >> ~/.bashrc
	export DOTNET_ROOT=~/dotnet
	export PATH=$DOTNET_ROOT:$DOTNET_ROOT/tools:$PATH

	mkdir ~/crank_dotnethome
	mkdir ~/crank_buildpath

	using System.Text.RegularExpressions;

	string file = await new HttpClient().GetStringAsync(
	"https://devblogs.microsoft.com/dotnet/performance-improvements-in-net-8/");

	MatchCollection pullRequestUrls =
	Regex.Matches(file, @"https:\/\/github.com\/[a-zA-Z-]+\/[a-zA-Z-]+\/pull\/[0-9]+");
	int total = pullRequestUrls.Count;
	int i = 1;

	using System.Text.RegularExpressions;

	/*

	Top25 Authors of all 512 PRs in https://devblogs.microsoft.com/dotnet/performance_improvements_in_net_7/
	(by count):

	stephentoub -- 148
	EgorBo -- 45
	tannergooding -- 26

	using System;
	using System.Text.Json;
	using System.Text.Json.Serialization;

	User? user = JsonSerializer.Deserialize<User>(
	await new HttpClient().GetStringAsync("https://jsonplaceholder.typicode.com/todos/1"), MyJsonContext.Default.User);

	Console.WriteLine($"id={user?.id}, title={user?.title}");

	public record User(int userId, int id, string title, bool completed);

	using System;
	using System.Runtime.CompilerServices;
	using System.Runtime.InteropServices;
	using System.Runtime.Intrinsics;

	unsafe class Program
	{
	[DllImport("kernel32")]
	static extern byte* VirtualAlloc(IntPtr addr, nuint size, uint typ, uint prot);