Created
October 1, 2017 19:13
-
-
Save JaciBrunning/aa55c75e4c9fc784743ecd945c57071a to your computer and use it in GitHub Desktop.
Gradle PR: Only adding 32 and 64 bit intel architectures for default toolchains
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
// After #1 | |
model { | |
// No user-defined toolchains have been added. | |
// Default toolchain gcc(Gcc) has been created and responds to Intel 32 and 64 bit architectures by default | |
toolChains { } | |
} | |
// After #2 | |
model { | |
// User-defined toolchain is added. | |
// Default Gcc name is used (gcc) and so Intel 32 and 64 bit architectures have been added | |
toolChains { | |
gcc(Gcc) { } | |
} | |
} | |
// After #3 | |
model { | |
// User-defined toolchain is added without default name. | |
// No longer responds to Intel 32 and 64 bit architectures by default (must be added by DSL) | |
toolChains { | |
otherGcc(Gcc) { } | |
} | |
} | |
// After #4 | |
model { | |
// Multiple User-defined toolchains added. | |
// Only gcc(Gcc) responds to Intel 32 and 64 bit architectures (default name) | |
// crossGcc(Gcc) only responds to the arm platform | |
toolChains { | |
gcc(Gcc) { } | |
crossGcc(Gcc) { | |
target("arm") { | |
// etc | |
} | |
} | |
} | |
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
// Before #1 | |
model { | |
// No user-defined toolchains have been added. | |
// Default toolchain gcc(Gcc) has been created and responds to Intel 32 and 64 bit architectures by default | |
toolChains { } | |
} | |
// Before #2 | |
model { | |
// User-defined toolchain is added with default name. | |
// Still responds to Intel 32 and 64 bit architectures | |
// Same behaviour exists if custom platform targets defined inside the gcc(Gcc) block | |
toolChains { | |
gcc(Gcc) { } | |
} | |
} | |
// Before #3 | |
model { | |
// User-defined toolchain is added without default name. | |
// Still responds to Intel 32 and 64 bit architectures | |
// Same behaviour exists if custom platform targets defined inside the otherGcc(Gcc) block | |
toolChains { | |
otherGcc(Gcc) { } | |
} | |
} | |
// Before #4 | |
model { | |
// Multiple User-defined toolchains added. Both toolchains respond to Intel 32 and 64 bit architectures | |
// Only crossGcc responds to the arm platform as well. | |
toolChains { | |
gcc(Gcc) { } | |
crossGcc(Gcc) { | |
target("arm") { | |
// etc | |
} | |
} | |
} | |
} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment