Last active
August 29, 2015 14:03
-
-
Save fire/d161a682e4a1a69d8633 to your computer and use it in GitHub Desktop.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sat, 28 Jun 2014 20:42:02 -0700 | |
<iFire> How do you adjust the quality of the stream and the output format? | |
<andrewrk> iFire, it's hard coded at the moment | |
<iFire> I want to change the hard code | |
<andrewrk> lib/player.js line 290 | |
<andrewrk> this.grooveEncoder.bitRate = 256 * 1000; | |
<andrewrk> do you want to make it something other than mp3? | |
<iFire> yeah | |
<andrewrk> which? | |
<iFire> andrewrk: I want to see if I can output alac | |
<andrewrk> I plan to default it to vorbis, however there is a bug fix in libav that I submitted that we have to wait until it is released | |
<andrewrk> here is all the places you need to change: https://github.com/andrewrk/groovebasin/commit/bc8e9fffd2091bad23a571e3b2740ccc0f33d90f | |
<iFire> seems like chrome doesn't like alac | |
<iFire> http://audiocogs.org/codecs/alac/ | |
<iFire> I think alac is better than flac because alac is native on ios | |
<andrewrk> I like flac better | |
<andrewrk> alac used to be proprietary | |
<andrewrk> and it has apple in the name | |
<andrewrk> so flac is working ok? | |
<iFire> andrewrk: to be honest either of them is interchangable | |
<iFire> usage wise | |
<iFire> you'd just be looking at hardware support | |
<iFire> but as that site notes, you can do it in js | |
<iFire> alac, mp3, flac, aac in js | |
<iFire> andrewrk: flac.js decoder is lgpl | |
<iFire> alac.js is apache |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment