Skip to content

Instantly share code, notes, and snippets.

@flooose
Created November 19, 2010 14:51
Show Gist options
  • Select an option

  • Save flooose/706602 to your computer and use it in GitHub Desktop.

Select an option

Save flooose/706602 to your computer and use it in GitHub Desktop.
In the last two weeks things here have continued to roll ahead.
The 0.0.3 Tag has been pushed github and here's a short summary of what's changed in the last couple of weeks.
First we've extracted "activesupport-slices":https://github.com/svenfuchs/activesupport-slices into a gem. We've also extracted has_one_default from the Page.article associations and ActiveRecord::Base.categorizable.
In terms of what's been refactoring, we've changed the blog_post route so that we no longer need a fake route. polymorphic url_for has also been reworked a bit. It's not yet complete, but it does already support multiple compinations of sti models. For example, url_for([blog, post]) will check blog_post_path, blog_content_path, section_post_path and section_content_path and use the first one that the view responds to.
Other things that got some attention in the past couple of weeks are the Section#path method and the blog pages. Posts that are assigned to a category's sub-categories are now included in their parent.
We've temporarily fixed a failing setup....????
extract has_one_default from Page.article association
extract activesupport-slices to a separate gem
extract ActiveRecord::Base.categorizable
add indices on categorizations
move flash from partial to base layout and fix missing user registration confirmation flash message
refactor blog_post route so we don't need a fake route any more
refactor polymorphic url_for [1]
refactor category url_helper_slice to fix reloading bug
fix installation/new protection message
fix Section#path method
fix blog category pages so that posts assigned to a category's subcategories are included
temporary fix failing test setup (migrations seem to crash w/ default_scope and preloading slices)
in adva test/setup require patches and register slice_paths before running migrations (because migrations might require files)
[1] still needs work, but now already supports multiple combinations of sti models. E.g. url_for([blog, post] will check the following methods and use the first one the view responds to: blog_post_path, blog_content_path, section_post_path, section_content_path
@svenfuchs

Copy link
Copy Markdown

In the last two weeks things here have continued to roll ahead.

The 0.0.3 Tag has been pushed to Github and here's a short summary of what's
changed in the last couple of weeks.

Amongst other things we've extracted
"activesupport-slices":https://github.com/svenfuchs/activesupport-slices into
a separate gem tagged as "lazy loaded vertical code slices based on
ActiveSupport Dependencies". See the
"readme":https://github.com/svenfuchs/activesupport-slices for details.

Also on framework level: we've reworked our "polymorphic url_for" extension
which still needs some love, but now already supports multiple combinations of
sti models. E.g. url_for([blog, post]) will check the following methods and
use the first one the view responds to: blog_post_path, blog_content_path,
section_post_path, section_content_path. This work eventually should lead to a
Rails patch, which might have some good chances to "be
accepted":https://rails.lighthouseapp.com/projects/8994-ruby-on-rails/tickets/2986-polymorphic_url-should-handle-sti-better

Some of the I18n related changes we've mentioned in my last post were
extracted to the
"i18n-missing_translations":https://github.com/svenfuchs/i18n-missing_translations
gem and will be part of the upcoming I18n 0.5.0 release and its Rails 3
integration respectively.

Highlights:

Minor changes:

  • refactor blog_post route so we don't need a fake route any more
  • refactor polymorphic url_for [1]
  • refactor category url_helper_slice and fix reloading bug
  • move flash from partial to base layout and fix missing user registration confirmation flash message
  • add indices on categorizations

Fixes:

  • fix installation/new protection message
  • fix Section#path method
  • fix blog category pages so that posts assigned to a category's subcategories are included
  • temporary fix failing test setup (migrations seem to crash w/ default_scope and preloading slices)
  • in adva test/setup require patches and register slice_paths before running migrations (because migrations might require files)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment