Refactor Spectacular - List to String

buildFeaturePreview-final.js

buildFeaturePreview(vehicle: IVehicle): string {
  let mpg = this.shouldShowMpg(vehicle) ? `${vehicle.MPGCity} / ${vehicle.MPGHighway} MPG` : null;
  let features = vehicle.HighlightedFeatures.map(feature => feature.description);
  
  return [mpg, 
          ...features]
          .filter(isDefinedAndNotNull)
          .join(', ')
          '...';
}

buildFeaturePreview-init.js

buildFeaturePreview(vehicle: IVehicle): string {
  let featureList: string[] = [];
  let features: string = '';

  if (shouldShowMpg(vehicle)) {
    featureList.push(`${vehicle.MPGCity} / ${vehicle.MPGHighway} MPG`);
  }

  vehicle.HighlightedFeatures  // HighlightedFeatures = [{ .description }]
    .map(feature => {
      featureList.push(`${feature.description}`);
    });

  features = featureList.join(', ');
  features += '...';

  return features;
}

helpers.js

isDefinedAndNotNull(o) {
  return typeof o !== 'undefined && o !== null;
}

shouldShowMpg(vehicle: IVehicle): boolean {
  return (
    isDefinedAndNotNull(vehicle) &&
    (isDefinedAndNotNull(vehicle.MPGCity) && vehicle.MPGCity !== 0) &&
    (isDefinedAndNotNull(vehicle.MPGHighway) && vehicle.MPGHighway !== 0)
  );
}