-
-
Save ifandelse/4617996 to your computer and use it in GitHub Desktop.
// Example UMD wrapper for a module that takes dependencies on underscore and postal.js | |
(function ( root, factory ) { | |
if ( typeof module === "object" && module.exports ) { | |
// Node, or CommonJS-Like environments | |
// Intentionally returning a factory method | |
module.exports = function( _, postal ) { | |
return factory( _, postal ); | |
} | |
} else if ( typeof define === "function" && define.amd ) { | |
// AMD. Register as an anonymous module. | |
define( ["underscore", "postal"], function ( _, postal ) { | |
return factory( _, postal, root ); | |
} ); | |
} else { | |
// Browser globals | |
factory( root._, root.postal, root ); | |
} | |
}( typeof global !== "undefined" ? global : this.window || this.global, function ( _, postal, global, undefined ) { | |
// module code here.... | |
}); |
I've never seen this === document
. That's strange, and if jsfiddle is doing that, then they should expect problems. :)
typeof window !== 'undefined' ? window : this
This will result in exports
in node.js. That's probably not what you want, I'm guessing. If you want the global object in node.js, you need to sniff for it, unfortunately. The following short expression will work in "normal" browser environments and ringojs. This might solve the this === document
scenario, too.
this && this.window || this.global
Too bad that won't work in node. The following will, though:
typeof global !== "undefined" && global
What if we just combined these? Hmmm, if this
isn't defined, there are bigger problems, so maybe just assume it is?
// look for node-like, browser-like, then ringo
typeof global !== "undefined" ? global : this.window || this.global
What do you think of that? I kinda like it and might start using it now. :)
@unscriptable - seriously, man, you are my code hero. First, to answer your question: I'm opting for the factory in node because I often have situations where I want the same instance of a dependency to be passed in to multiple factories. postal is good example, as the add-ons for it need to target the same instance. It's one of the nice by-nature-of-design aspects of AMD, IMO - singletons are easy. I wish node had that capability built in. If you think of something I'm missing here, let me know.
I like your idea a lot - makes tons of sense. Not sure why this.window
didn't occur to me! smacks forehead. I updated the gist to reflect your input....
Yah, I almost slapped my own forehead when I realized this.window
finds window
when this == window
or document == window
. Kinda neat.
It's still unclear to me why you need to export a factory for node in order to support singletons. Maybe I just haven't played with node enough to know why singletons can be a problem. Is this why? Interesting. So how is that factory called? How do you get the "true singletons" into that factory? (Sorry if I'm being too curious for you. :) )
Oops. just saw your comment that you're intentionally returning a factory. That's interesting. Why are you doing that?