Skip to content

Instantly share code, notes, and snippets.

@raghubetina

raghubetina/code_review_workflow.md

Created February 5, 2018 18:05
Show Gist options
  • Save raghubetina/07d1b75946738bf24279c9fb9b625f83 to your computer and use it in GitHub Desktop.
Save raghubetina/07d1b75946738bf24279c9fb9b625f83 to your computer and use it in GitHub Desktop.
Download ZIP
Code Review Workflow
Raw
code_review_workflow.md

Code Review workflow

  • Open a PR
  • Request review in #review-requests. If you need a specific person's feedback, @mention them.
  • Even if you aren't specifically mentioned, try to look at every PR at least briefly — remember that Code Review is about knowledge-sharing/asking-questions more than catching bugs.
  • If you haven't watched it recently, watch Derek's talk again: https://www.youtube.com/watch?v=PJjmw9TRB7s
  • If you haven't watched it recently, watch Ben and Joe's video again: https://thoughtbot.com/upcase/videos/tips-for-code-review
  • If you haven't gone through it recently, remind yourself about the Git Workflow again: https://thoughtbot.com/upcase/videos/git-thoughtbot-git-flow
  • I've currently set frequently used repos to post PR comments to #review-requests. (Is this too much noise?)
  • If you've been waiting for feedback and the lack of feedback is blocking you, re-request (with @mentions).
  • If you've addressed comments and want another review, re-request in #review-requests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment