marin-community/marin#1646 Pin levanter[serve] to 775ac7c6
- Since Sept '241, Marin's Levanter dep was a "pin" of the form
>=1.2.devNNNN- When Levanter PRs land,
1.2.devNNNNversions are published by publish_dev.yml- e.g. levanter#1127 → publish_dev#315 → 1.2.dev1500
- If Marin needs the changes, it may bump its pin
- e.g. marin#1522 / pin
- Marin may have frequently skipped a Levanter bump, when it actually needed more recent changes, since the convention was use
>=rather than==
- When Levanter PRs land,
- #1591 moved to a
==pin (levanter==1.2.dev1535) - #1616 moved to a "floating" dep (against levanter@main)
It would be good to properly pin this dep, and get a better sense of how "linked" PRs to each repo tend to be.
- If Marin PRs frequently require a corresponding Levanter PR, we may want to move Levanter src into this repo.
- openathena.s3.amazonaws.com/marin-levanter.html implies that 5-10% of PRs in each repo are linked in this way, but it may have false-negatives that rely on the
>=.
The current floating dep (and previous >=) can cause a given Marin SHA to behave differently (or break) over time. uv.lock might mitigate this, but I'd like to try properly pinning the Marin→Levanter dep, to get some real data about how synced the 2 repos are (and keep things repro-able / deterministic, and shore up DX / dep-mgmt issues that the floating pins were working around).
To that end, this pins https://github.com/marin-community/levanter/commit/775ac7c6c6f913fd9fed263b26bdb7169df349cc (current levanter@main).
Footnotes
-
Since #224 /
levanter>=1.1.dev992, Sept '24 ↩