Skip to content

Instantly share code, notes, and snippets.

View ryan-williams's full-sized avatar
🚆

Ryan Williams ryan-williams

🚆
View GitHub Profile

[marin-community/marin#1726] Fix KL loss in the RL training.

Description

A few fixes for RL training.

  • We were computing tokens incorrectly by decoding from the token text vs from the logprob tokens. These can diverge when there are special tokens in the output.
  • Our KL loss was calculating the KL divergence, but not actually a penalty - the model was encouraged to diverge from the reference.
  • We were using the "old" mesh syntax in a number of locations.

runsascoded/ghpr#3 Test link reference format

This tests that the link reference is in the footer, not inline.

@ryan-williams
ryan-williams / stdlb#2.md
Created October 26, 2025 16:12
runsascoded/stdlb#2 (pr) - 2-way sync via github-pr.py (ryan-williams/git-helpers)

[runsascoded/stdlb#2] Snapshot testing, collision fixes, and src/ layout

Summary

This PR adds comprehensive snapshot testing to prevent regressions, fixes name collision issues discovered when comparing to v0.0.4, and reorganizes the codebase with a src/ layout.

Key Changes

  • Snapshot testing (scripts/snapshot_exports.py, tests/test_exports_snapshot.py)
  • Tracks all 2127 exported symbols with their FQNs

[marin-community/marin#1723] "Workspace" step 2: experimentsmarinlevanter

Second step in the "uv workspace migration plan" ([#1773]):

  • Merge [Levanter] into lib/levanter/ (preserving full Git history)
  • Migrate GitHub Actions workflows to monorepo structure
  • Builds on: [#1690] (workspace initialization)
  • Next step: [Step 3][step3] (Thalas executor - TODO)
flowchart LR
@ryan-williams
ryan-williams / marin#1690.md
Last active November 3, 2025 20:54
marin-community/marin#1690 - 2-way sync via github-pr.py (ryan-williams/git-helpers)

[marin-community/marin#1690] "Workspace" step 1: experimentsmarin

First step in the "uv workspace migration plan" ([#1773]):

  • Initialize a [uv workspace][workspaces]
  • Move the marin package into lib/marin/
  • experiments/ remain in "root" target, which depends on marin
  • Next step: [#1723] (Levanter integration)
flowchart LR
@ryan-williams
ryan-williams / marin#1646.md
Last active September 25, 2025 15:16
marin-community/marin#1646 - 2-way sync via github-pr.py (ryan-williams/git-helpers)

[marin-community/marin#1646] Pin levanter[serve] to 775ac7c6

  • Since Sept '24[^1], Marin's Levanter dep was a "pin" of the form >=1.2.devNNNN
    • When Levanter PRs land, 1.2.devNNNN versions are published by [publish_dev.yml]
      • e.g. [levanter#1127] → [publish_dev#315] → [1.2.dev1500]
    • If Marin needs the changes, it may bump its pin
      • e.g. [marin#1522][#1522] / [pin][levanter>=1.2.dev1500 pin]
      • Marin may have frequently skipped a Levanter bump, when it actually needed more recent changes, since the convention was use >= rather than ==
  • [#1591] moved to a == pin ([levanter==1.2.dev1535])
  • [#1616] moved to a "floating" dep (against [levanter@main])
@ryan-williams
ryan-williams / git-helpers#104.md
Created September 24, 2025 17:27
ryan-williams/git-helpers#104 (issue) - 2-way sync via github-pr.py (ryan-williams/git-helpers)

[ryan-williams/git-helpers#104] 'add-global-file' is not a git command

I took this for a spin and encountered an issue with what I'm guessing is an unported script...

> . .git-rc
git: 'add-global-config-file' is not a git command. See 'git --help'.

I dug into this a bit and ended up provisionally including the config/.gitconfig into my ~/.gitconfig by hand. Then...

@ryan-williams
ryan-williams / git-helpers#1.md
Created September 24, 2025 17:16
ryan-williams/git-helpers#1 (issue) - 2-way sync via github-pr.py (ryan-williams/git-helpers)

ryan-williams/git-helpers#1 Add issues command, which opens github issues for a repo

Just came up with this command, I think it's gonna be great!

While you're in a git repo on your command line, you run issues and it opens the github issues for that repo in your browser.