Skip to content

Instantly share code, notes, and snippets.

View ryan-williams's full-sized avatar
🚆

Ryan Williams ryan-williams

🚆
View GitHub Profile

[runsascoded/ghpr#6] Improve help text, refactor command registration, and fix test assertions

This PR includes three improvements to the ghpr codebase:

1. Better Help Text and Validation

  • Draft flag validation - Added error when using -d without -y, since draft mode is incompatible with web editor
  • Clearer help text - Updated create command and flag descriptions to clearly explain the three modes:
    • Default (no -y): Interactive web editor (waits for user)
    • -y once: Create via API then view result

[runsascoded/ghpr#5] Improve create and init workflows

This PR includes several improvements to the create and init commands, making the PR/Issue creation workflow more robust and user-friendly.

Key Changes

Template and Workflow

  1. Remove placeholder confusion - Templates now use plain # Title format; link-references added automatically after PR/Issue creation
  2. Interactive web editor support - Default mode opens browser, waits for user confirmation, then fetches PR info and updates file
@ryan-williams
ryan-williams / DESCRIPTION.md
Created November 8, 2025 23:07
Draft PR for test-owner/test-repo

[marin-community/marin#1967] "Workspace" step 3: Ingest haliax as lib/haliax/

Third step in the "uv workspace migration plan" ([#1773]):

  • Merge [Haliax] into lib/haliax/ (preserving full Git history)
  • Migrate GitHub Actions workflows to monorepo structure
  • Builds on: [#1723] ("step 2", Levanter integration)
  • Next step: [Step 4][step4] (Thalas executor)
flowchart TB

[marin-community/marin#1726] Fix KL loss in the RL training.

Description

A few fixes for RL training.

  • We were computing tokens incorrectly by decoding from the token text vs from the logprob tokens. These can diverge when there are special tokens in the output.
  • Our KL loss was calculating the KL divergence, but not actually a penalty - the model was encouraged to diverge from the reference.
  • We were using the "old" mesh syntax in a number of locations.

runsascoded/ghpr#3 Test link reference format

This tests that the link reference is in the footer, not inline.

@ryan-williams
ryan-williams / stdlb#2.md
Created October 26, 2025 16:12
runsascoded/stdlb#2 (pr) - 2-way sync via github-pr.py (ryan-williams/git-helpers)

[runsascoded/stdlb#2] Snapshot testing, collision fixes, and src/ layout

Summary

This PR adds comprehensive snapshot testing to prevent regressions, fixes name collision issues discovered when comparing to v0.0.4, and reorganizes the codebase with a src/ layout.

Key Changes

  • Snapshot testing (scripts/snapshot_exports.py, tests/test_exports_snapshot.py)
  • Tracks all 2127 exported symbols with their FQNs

[marin-community/marin#1773] "Workspace" monorepo plan

(Versioned write-up [here][gist], synced via [ghpr])

Status

  • ✅ [#1690] (step 1): Init workspace, move marin to lib/marin/
  • ✅ [#1723] (step 2): Ingest [Levanter] as lib/levanter/
  • 🚧 Step 3: Ingest [Haliax] as lib/haliax/

[marin-community/marin#1723] "Workspace" step 2: experimentsmarinlevanter

Second step in the "uv workspace migration plan" ([#1773]):

  • Merge [Levanter] into lib/levanter/ (preserving full Git history)
  • Migrate GitHub Actions workflows to monorepo structure
  • Builds on: [#1690] ("step 1", workspace initialization)
  • Next step: [Step 3][step3] (Haliax integration)
flowchart TB