Skip to content

Instantly share code, notes, and snippets.

@kaylagordon

kaylagordon/Rachel + Shawn.md

Forked from niksseif/Rachel + Shawn.md
Last active February 17, 2021 23:39
Show Gist options
  • Save kaylagordon/06c3c069264c28cc9105cd46a3579313 to your computer and use it in GitHub Desktop.
Save kaylagordon/06c3c069264c28cc9105cd46a3579313 to your computer and use it in GitHub Desktop.
Download ZIP
Rachel + Shawn, Hang in there paired project
Raw
Rachel + Shawn.md

Hang In There Pair Project

Thanks for your work on this project!

Rubric score key (applies only to that section of the rubric):

  • 4: went beyond set learning goals; did self-teaching.
  • 3: exactly on track! great work!
  • 2: a little behind where we want to see you; study in this area to level up
  • 1: significantly behind where we want to see you; let’s do some pairing!

🙌 Notes on things to keep doing
🌱 Notes on things to improve on

Professionalism: 3
🙌 Commits are super even. Really good commit:PR ratio - there should always be multiple commits on each PR. Commits messages are consistent. 🙌 Great work tagging each other in code reviews! Usually you want a code review to include some back and forth conversation (this is hard in Mod1, b/c you pair on so much of the code), but think about that for next time!
🌱 Your README looks pretty good. I recommend including a gif of your app in your READMEs to give people a preview of your app.

JavaScript Style & Implementation: 2.5
🙌 Your code is clean, easy to follow, and indented very well.
🙌 Great work using your knowledge of falsyness to keep your conditionals concise in saveCreatedposter function!
🌱 Make sure you are updating the data model (savedPosters) when you delete a poster. In your deletePoster function, you're only deleting it from the DOM, but not from that array.
🌱 You could have consolidated your hideMainForm and hideSideForm into one function if you added a second parameter.

Functional Expectations: 0
Note: The reason you're getting a 0 here is because you have bugs in iteration 0 and 4.

On page load, this appears instead of a random poster: broken site

Also, when you double click on the poster, the whole poster does not delete, but each individual element.

I know you got through all of the iterations, which is great and you should feel really proud of that. Remember - these scores hold very little (basically none) weight when it comes to promoting to the next mod - the real value in the feedback is to learn from it and not repeat mistakes. A 1 early on can be a powerful reminder for future projects that carry more weight.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment