Skip to content

Instantly share code, notes, and snippets.

View stacey-gammon's full-sized avatar

Stacey Gammon stacey-gammon

12 followers · 5 following
View GitHub Profile
@stacey-gammon
stacey-gammon / new_migration_fn.md
Last active June 17, 2021 13:59
Persistable state migration fn 
interface PersistableStateService {
  getMigrations: { [key: string]: MigrationFn }
}


function collectDashboardPanelMigrations(): { [key:string]: MigrationFn } {
  // Dashboard plugin may have registered some of it's own panel migrations.
  const panelMigrations: { [key:string]: MigrationFn } = {
@stacey-gammon
stacey-gammon / persistable_state_embeddable_clashes.md
Created July 29, 2020 18:03

Corner cases:

  1. Registrar wants to add a migration to every registry item. Specific example: Author of Embeddable api wants to migrate base EmbeddableInput.
  2. Enhancer wants to add a migration to every registry item. Specific example: Author of EnhancedEmbeddableDrilldowns wants to migrate EnhancedEmbeddableInput.
  3. Registrator wants to add a migration to it's specific registry item. Example: Author of Visualize plugin wants to migrate VisualizeEmbeddableInput

Corner case 1 & avoiding clashes.

@stacey-gammon
stacey-gammon / persistable_state_plugin.md
Last active May 7, 2020 14:22

Persistable state plugin

Corner cases

  1. Registrar wants to add a migration to every registry item. Example: Author of Embeddable api wants to migrate base EmbeddableInput.
  2. Enhancer wants to add a migration to every registry item. Author of EnhancedEmbeddableDrilldowns wants to migrate EnhancedEmbeddableInput.
  3. Registrator wants to add a migration to it's specific registry item. Example: Author of VisState wants to migrate VisualizeEmbeddableInput
@stacey-gammon
stacey-gammon / data_table_abstraction_ideas.md
Last active November 27, 2019 14:52 
class InMemoryTable extends IDataTable {
  // basic impl of all the funcs on an in memory table.
}

interface IDataTable {
  narrow(narrowingQuery: INarrowingQuery): IDataTable;
  selectColumns(columns: string[]): IDataTable;
  groupBy(aggs: Aggs): IDataTable;
  getFieldSuggestions(fieldPrefix: string): IDataTable;
@stacey-gammon
stacey-gammon / Typescriptifying.md
Last active October 4, 2018 18:47

Typescriptifying Kibana Tips

Converting existing code

To convert existing code over to typescript:

  1. rename the file from .js to either .ts (if there is no html or jsx in the file) or .tsx (if there is).
  2. Ensure tslint is running and installed in the IDE of your choice. There will usually be some linter errors after a save.
  3. Auto-fix what you can. This will save you a lot of time! I have VSCode set to auto fix tslint errors when I save the file.

How to fix common typescript errors

@stacey-gammon
stacey-gammon / embeddables.md
Last active March 12, 2018 17:00
Dashboard and Embeddable Redux State Exploration

Dashboard Redux State Tree:

{
  id: string,
  title: string,
  
  timeRange: {
    from: string,
@stacey-gammon
stacey-gammon / Embeddables.md
Created March 6, 2018 18:48

Panel loaded on a dashboard

// dashboard_panel.js
async componentDidMount() {
  this.props.renderEmbeddable(this.panelElement, this.props.panel);
}

render() {
  return (
    <div
@stacey-gammon
stacey-gammon / KibanaTODOList.md
Last active June 5, 2017 18:52
Stacey's TODO List
@stacey-gammon
stacey-gammon / ReactStyleGuide.md
Last active March 8, 2017 00:13

React Style Guide

Prefer Stateless functional components where possible.

Stateless function components are more concise, and there are plans for react to increase performance of them. Good:

export function KuiButton({ onClick, isDisabled }) {
  return <button className="kuiButton" onClick={onClick} isDisabled={isDisabled}/>
};